Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill missing peer addrs via second lookup #11

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fill missing peer addrs via second lookup #11

merged 1 commit into from
Jan 31, 2023

Conversation

masih
Copy link
Member

@masih masih commented Jan 31, 2023

When addrs are missing in a provider record, attempt to fill them by performing a second lookup over the routing.PeerRouting interface.

Fixes #9

@masih
Fill missing peer addrs via second lookup
dfcfd2f 
When addrs are missing in a provider record, attempt to fill them by
performing a second lookup over the `routing.PeerRouting` interface.

Fixes #9
@masih masih requested a review from willscott January 31, 2023 11:29
@masih masih mentioned this pull request Jan 31, 2023
Closed
@masih masih requested a review from ischasny January 31, 2023 11:34
willscott
willscott approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree this is preferable to exposing and having to keep supporting a findPeer endpoint

@masih masih merged commit 1b45048 into main Jan 31, 2023
@masih masih deleted the masih/fill_empty_addrs branch January 31, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ischasny ischasny ischasny approved these changes

@willscott willscott willscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No multiaddrs returned from provider record lookups
3 participants
@masih @willscott @ischasny