Add Attention Test Suite #37
Open
+1,418
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
ScottTodd
reviewed
Nov 11, 2024
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
Signed-off-by: erman-gurses <[email protected]>
|
@ScottTodd, do we have any other comment from your side? If not, can you approve this? |
ScottTodd
approved these changes
Nov 15, 2024
Comment on lines
211
to
219
| iree_hal_buffer_t* query_buffer = iree_hal_buffer_view_buffer(query); | ||
| iree_hal_buffer_t* key_buffer = iree_hal_buffer_view_buffer(key); | ||
| iree_hal_buffer_t* value_buffer = iree_hal_buffer_view_buffer(value); | ||
| iree_hal_buffer_t* result_buffer = iree_hal_buffer_view_buffer(result); | ||
| iree_hal_buffer_t *query_buffer = iree_hal_buffer_view_buffer(query); | ||
| iree_hal_buffer_t *key_buffer = iree_hal_buffer_view_buffer(key); | ||
| iree_hal_buffer_t *value_buffer = iree_hal_buffer_view_buffer(value); | ||
| iree_hal_buffer_t *result_buffer = iree_hal_buffer_view_buffer(result); |
There was a problem hiding this comment.
move * characters back to the type, not the variable name? clang-format will follow the dominant style in the file, so you may need to change a few
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on this #2
This PR refactors, adds, and migrates Attention e2e tests from the PR here: iree-org/iree#18320