[ExportedProgram] Add mutable attribute to buffer #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrsmcgrr
force-pushed
the
mcgirr/roo-43-fix-kv-cache-issue-for-torch-buffers
branch
2 times, most recently
from
ed09e6a
to
bbc098d
Compare
|
Requires newer version of IREE containing the torch-mlir change: #151 |
chrsmcgrr
force-pushed
the
mcgirr/roo-43-fix-kv-cache-issue-for-torch-buffers
branch
from
735c209
to
2a7058f
Compare
Actually this PR did not have the IREE changes that were required. A newer release is needed. |
maxbartel
pushed a commit
that referenced
this pull request
Sep 20, 2024
ci(iree): update version to release 20240918.1020 This update is required for another PR #123 Signed-off-by: Christopher McGirr <[email protected]>
|
Could you rebase, please? The tests should now pass |
Signed-off-by: Christopher McGirr <[email protected]>
chrsmcgrr
force-pushed
the
mcgirr/roo-43-fix-kv-cache-issue-for-torch-buffers
branch
from
2a7058f
to
d07db5f
Compare
|
@stellaraccident This seems to work now with the newest IREE bump. Can we get a review from you please? |
stellaraccident
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Amazing -- I don't know if you truly know how many things had to come together to make that work. I've been slowly making progress on that functionality for the past year because it seemed very useful to get mapped right, but I didn't know we were so close to having it fully working.
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
ci(iree): update version to release 20240918.1020 This update is required for another PR iree-org#123 Signed-off-by: Christopher McGirr <[email protected]>
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
Fixes iree-org#85 PR based on the work of @maxbartel Requires changes in torch-mlir: [llvm/torch-mlir/#3688](llvm/torch-mlir#3688) Adds the mutable modifier to a global buffer and lifts said buffer to a global if there is a store-producer node associated with it. Signed-off-by: Christopher McGirr <[email protected]> Co-authored-by: Maximilian Bartel <[email protected]>
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
ci(iree): update version to release 20240918.1020 This update is required for another PR iree-org#123 Signed-off-by: Christopher McGirr <[email protected]> Signed-off-by: Ian <[email protected]>
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
Fixes iree-org#85 PR based on the work of @maxbartel Requires changes in torch-mlir: [llvm/torch-mlir/#3688](llvm/torch-mlir#3688) Adds the mutable modifier to a global buffer and lifts said buffer to a global if there is a store-producer node associated with it. Signed-off-by: Christopher McGirr <[email protected]> Co-authored-by: Maximilian Bartel <[email protected]> Signed-off-by: Ian <[email protected]>
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
ci(iree): update version to release 20240918.1020 This update is required for another PR iree-org#123 Signed-off-by: Christopher McGirr <[email protected]> Signed-off-by: Ian <[email protected]>
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
Fixes iree-org#85 PR based on the work of @maxbartel Requires changes in torch-mlir: [llvm/torch-mlir/#3688](llvm/torch-mlir#3688) Adds the mutable modifier to a global buffer and lifts said buffer to a global if there is a store-producer node associated with it. Signed-off-by: Christopher McGirr <[email protected]> Co-authored-by: Maximilian Bartel <[email protected]> Signed-off-by: Ian <[email protected]>
stellaraccident
pushed a commit
that referenced
this pull request
Oct 13, 2024
Fixes #85 PR based on the work of @maxbartel Requires changes in torch-mlir: [llvm/torch-mlir/#3688](llvm/torch-mlir#3688) Adds the mutable modifier to a global buffer and lifts said buffer to a global if there is a store-producer node associated with it. Signed-off-by: Christopher McGirr <[email protected]> Co-authored-by: Maximilian Bartel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85
PR based on the work of @maxbartel
Requires changes in torch-mlir: llvm/torch-mlir/#3688
Adds the mutable modifier to a global buffer and lifts said buffer to a global if there is a store-producer node associated with it.