Reorder the nodes in the graph to match the dim expansion order #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-nod
force-pushed
the
riorder2
branch
4 times, most recently
from
4aba25f
to
48ac9f6
Compare
This PR modifies the order in which nodes are inserted into the graph to follow the canonical Cartesian product. This is especially important for the iter args inside a for loop that (without this PR) are not in the same order as the init args and outputs. By reordering the nodes, we ensure that the init args, iter args and outputs are all in the same order and map 1-1. Signed-off-by: Harsh Menon <[email protected]>
|
No longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the order in which nodes are inserted into the graph to follow the canonical Cartesian product. This is especially important for the iter args inside a for loop that (without this PR) are not in the same order as the init args and outputs. By reordering the nodes, we ensure that the init args, iter args and outputs are all in the same order and map 1-1.