Perf test experiments #224
Conversation
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
.github/workflows/perf.yaml
Outdated
| @@ -19,7 +16,8 @@ concurrency: | |||
|
|
|||
| jobs: | |||
| test: | |||
| name: "Unit Tests and Type Checking" | |||
| name: "Perf Tests" | |||
| if: ${{ github.event.issue.pull_request }} && contains(github.event.comment.body, '/turbine_run_perf') | |||
There was a problem hiding this comment.
You may want to look for a label being applied or validate the author of the comment somehow. This looks like any GitHub user (project member or not) could trigger the workflow by adding this comment. That increases the surface area for malicious behavior.
There was a problem hiding this comment.
I doesn't work anyway yet :)
There was a problem hiding this comment.
I will just probably create separate personal repo and experiment on it first
There was a problem hiding this comment.
https://github.com/iree-org/iree/blob/7d60397cbe62e8563a36ec286c41aa40d7e4e58d/.github/workflows/benchmark_trigger.yml might also be useful to reference (I'm sure there are other good references in other github projects, but that's what we used in iree-org/iree for a while)
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
No description provided.