Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeviceTensorTrait to export annotations #240

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

rsuderman
Copy link
Contributor

Exported globals can now be parked to belong to a specific device. This works with sharding tooling to ensure globals are not misassigned to the default affinity device

Exported globals can now be parked to belong to a specific device. This
works with sharding tooling to ensure globals are not misassigned to the
default affinity device
Copy link
Contributor

@sogartar sogartar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are inconsistent with the DeviceAffinity being an ordinal and this is using a the whole device name directly.

@rsuderman
Copy link
Contributor Author

We are inconsistent with the DeviceAffinity being an ordinal and this is using a the whole device name directly.

Addressed

@rsuderman rsuderman merged commit b81c6df into iree-org:main Oct 24, 2024
7 of 8 checks passed
@rsuderman rsuderman deleted the global_device branch October 24, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants