Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iree-requirements-ci.txt to the latest stable release. #254

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

ScottTodd
Copy link
Member

This release was just promoted to stable: https://github.com/iree-org/iree/releases/tag/candidate-20241104.1068. As we align the versions across projects (iree-org/iree#18938), we should aim to use stable versions or at least test nightly versions with care.

@ScottTodd
Copy link
Member Author

@harsh-nod @raikonenfnu can one of you help with the test failures?
https://github.com/iree-org/iree-turbine/actions/runs/11694495673/job/32568203851?pr=254#step:7:16

 # .---command stderr------------
# | /home/runner/work/iree-turbine/iree-turbine/lit_tests/kernel/wave/codegen.py:1156: error: Couldn't match "func.func @gemm_pipelined".
# | Current position at <stdin>:1092:20
# |           scf.yield %94, %97, %96, %95 : vector<4xf32>, vector<4xf32>, vector<4xf32>, vector<4xf32>
# |                    ^
# `-----------------------------

@harsh-nod
Copy link
Contributor

Here is the fix for the llvm error:

diff --git a/iree/turbine/kernel/wave/codegen.py b/iree/turbine/kernel/wave/codegen.py
index b2b1c6a..8e0c056 100644
--- a/iree/turbine/kernel/wave/codegen.py
+++ b/iree/turbine/kernel/wave/codegen.py
@@ -1139,7 +1139,7 @@ def handle_scheduling_group_barrier(emitter: WaveEmitter, node: fx.Node):
         mask = arith_d.constant(IntegerType.get_signless(32), mask)
         counts = arith_d.constant(IntegerType.get_signless(32), counts)
         llvm_d.call_intrinsic(
-            None, "llvm.amdgcn.sched.group.barrier", [mask, counts, sync_id]
+            None, "llvm.amdgcn.sched.group.barrier", [mask, counts, sync_id], [], []
         )

Do you want to add it to this PR?

@harsh-nod
Copy link
Contributor

This fixes:

TypeError: call_intrinsic() missing 2 required positional arguments: 'op_bundle_operands' and 'op_bundle_sizes'

and may also fix the subsequent error.

@ScottTodd
Copy link
Member Author

Thanks! Pushed that commit. I think you can also push to the branch in my fork (though it takes a bit more effort than if I made this branch in this repo).

Copy link
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ScottTodd ScottTodd marked this pull request as ready for review November 6, 2024 16:59
@ScottTodd ScottTodd merged commit 3db957c into iree-org:main Nov 6, 2024
6 of 8 checks passed
@ScottTodd ScottTodd deleted the iree-stable-bump branch November 6, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants