-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial CI #4
Conversation
.github/workflows/test_models.yml
Outdated
|
||
jobs: | ||
test-turbine-models-cpu: | ||
runs-on: ubuntu-22.04-64core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in your comment, let's not do this. This costs $$ to GitHub and would be better to use one of our self managed instances.
.github/workflows/test_shark.yml
Outdated
strategy: | ||
matrix: | ||
version: [3.11] | ||
os: [ubuntu-22.04-64core] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This commit brings over all the CI from SHARK-Turbine and configures it properly for iree-turbine. I also add parallelization to the model testing, so that the cpu model tests run on ubuntu 64 core and gpu tests run on mi250. This way we only hog the mi250 for 4 mins compared to the ~30 mins in SHARK Turbine (we use mi250 for gpu model regression testing on iree PRs so wanted to reduce time being used to only necessity). I didn't see anywhere in iree-org that solely depends on ubuntu 64 core so I don't think we would be blocking anywhere by hogging for while. But, let me know if we want further parallelization due to github runner cost of using 64 core (I can try and see if we can get some of the sd tests running on 32 or 16 core even)