Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add camera local frame setter and both local and global frame getter #1034

Open
1 of 4 tasks
lhy0807 opened this issue Sep 24, 2024 · 1 comment · May be fixed by #1174
Open
1 of 4 tasks

[Proposal] Add camera local frame setter and both local and global frame getter #1034

lhy0807 opened this issue Sep 24, 2024 · 1 comment · May be fixed by #1174
Labels
dev team Issue or pull request created by the dev team enhancement New feature or request

Comments

@lhy0807
Copy link

lhy0807 commented Sep 24, 2024

Proposal

The current implementation of the Camera sensor only exposes the global pose setter. However, pose getter and local pose setter is also needed for my project needs.

Motivation

I need to get the pose of the camera, however this getter function has not been implemented in the current Camera sensor interface. Setting the camera local pose is also needed.

Alternatives

I could get the pose using self._view. However, I think a more proper way is to expose this function in the Camera class.

Additional context

N/A

Checklist

  • I have checked that there is no similar issue in the repo (required)

Acceptance Criteria

Add the criteria for which this task is considered done. If not known at issue creation time, you can add this once the issue is assigned.

  • Add get_world_poses function to Camera class
  • Add set_local_poses function to Camera class
  • Add set_local_poses_from_view function to Camera class
@mpgussert mpgussert added the enhancement New feature or request label Oct 3, 2024
@mpgussert
Copy link
Collaborator

Hello @lhy0807 !

On a cursory examination of the code, I also wasn't able to find a way to get this information without directly accessing self._view. We already use this to set_world_pose of the camera, so we should probably have an equivalent get_world_pose in the same way. Local and other non global frame transformations would then be handled in the usual way. Good suggestion!

@mpgussert mpgussert added the dev team Issue or pull request created by the dev team label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev team Issue or pull request created by the dev team enhancement New feature or request
Projects
None yet
2 participants