Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved workarounds for win32, continued #131

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Improved workarounds for win32, continued #131

wants to merge 23 commits into from

Commits on Jul 19, 2019

  1. Stat from file to make sure it was renamed

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    bf4569d View commit details
    Browse the repository at this point in the history

  2. Resolve if source and destination is the same size

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    eb6c68d View commit details
    Browse the repository at this point in the history

  3. Except rename to not return an error

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    f37b06a View commit details
    Browse the repository at this point in the history

  4. Unlink source if it's the same as destination

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    e85b6c0 View commit details
    Browse the repository at this point in the history

  5. Do not unlink file

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    8c177e4 View commit details
    Browse the repository at this point in the history

  6. Add fs.renameSync for win32

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    e6c706e View commit details
    Browse the repository at this point in the history

  7. Remove extraneous line

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    34dadcf View commit details
    Browse the repository at this point in the history

  8. Improve stat compare between src and dest

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    0131d83 View commit details
    Browse the repository at this point in the history

  9. Ignore ENOENT for src on retry

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    e5e958f View commit details
    Browse the repository at this point in the history

  10. Wait until dest exist and src does not

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    3384945 View commit details
    Browse the repository at this point in the history

  11. Revamped rename tests

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    73cab41 View commit details
    Browse the repository at this point in the history

  12. Remove sneaky arrow functions

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    c6581c9 View commit details
    Browse the repository at this point in the history

  13. Updated comments and formatting

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    2a1fe1f View commit details
    Browse the repository at this point in the history

  14. Assume rename was successful if source no longer exists

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    476117a View commit details
    Browse the repository at this point in the history

  15. Make sure both statFrom and statTo are set

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    2ab3f15 View commit details
    Browse the repository at this point in the history

  16. Add additional comment about size/ctime comparison

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    d3dc056 View commit details
    Browse the repository at this point in the history

  17. Unlink target it if exists

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    5af97e5 View commit details
    Browse the repository at this point in the history

  18. Add test for renaming dirs

    @mekwall @jgoz
    mekwall authored and jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    17326a0 View commit details
    Browse the repository at this point in the history

  19. Reduce backoff to 5s, make configurable via env

    @jgoz
    jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    0e5e89a View commit details
    Browse the repository at this point in the history

  20. Guard cb calls

    @jgoz
    jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    43a6cb5 View commit details
    Browse the repository at this point in the history

  21. Ensure teardownDirs is called appropriately

    @jgoz
    jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    f5d0bfd View commit details
    Browse the repository at this point in the history

  22. Respect ENOTEMPTY errors from rmdir

    @jgoz
    jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    d7aad73 View commit details
    Browse the repository at this point in the history

  23. Formatting

    @jgoz
    jgoz committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    314e721 View commit details
    Browse the repository at this point in the history