Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spacing on grid #16683

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: spacing on grid #16683

wants to merge 2 commits into from

Conversation

disaerna
Copy link
Member

@disaerna disaerna commented Oct 31, 2024

UI Core - Grid layout

What

  • Add tablet spacing 24 px
  • Mobile spacing changed to 16 px

Why

Design changes
https://www.figma.com/design/BoE5KwltiuY0BR2MVkYlhC/Brand-Guide-%E2%80%93--%F0%9F%87%AE%F0%9F%87%B8Island.is?node-id=12283-96&node-type=frame&t=4JQLQpBYMlrbCDFv-0

Screenshots / Gifs

Screenshot 2024-10-31 at 14 17 08

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • Style
    • Updated padding properties for the GridContainer to enhance layout responsiveness.
    • Introduced a new media query for better padding adjustments on smaller screens.

@disaerna disaerna added the automerge Merge this PR as soon as all checks pass label Oct 31, 2024
@disaerna disaerna requested a review from a team as a code owner October 31, 2024 14:16
Copy link
Contributor

coderabbitai bot commented Oct 31, 2024

Walkthrough

The changes in the GridContainer.css.ts file primarily focus on modifying the padding properties for the root style based on screen size. The left and right padding values have been updated to utilize theme.spacing[2] for mobile screens, with a new media query introduced for larger screens that resets these values back to theme.grid.gutter.mobile * 2. The existing media query for medium-sized screens remains unchanged, continuing to apply a different padding value.

Changes

File Path Change Summary
libs/island-ui/core/src/lib/Grid/GridContainer/GridContainer.css.ts Updated paddingLeft and paddingRight for mobile screens, added media query for larger screens, and retained existing media query for medium screens.

Suggested labels

high priority

Suggested reviewers

  • thordurhhh

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@disaerna disaerna added deploy-feature Deploys features to dev and removed automerge Merge this PR as soon as all checks pass labels Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.64%. Comparing base (dc89848) to head (a76e682).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16683   +/-   ##
=======================================
  Coverage   36.63%   36.64%           
=======================================
  Files        6873     6873           
  Lines      143137   143090   -47     
  Branches    40806    40777   -29     
=======================================
- Hits        52445    52431   -14     
+ Misses      90692    90659   -33     
Flag Coverage Δ
air-discount-scheme-web 0.00% <ø> (ø)
api 3.37% <ø> (ø)
application-api-files 56.78% <ø> (ø)
application-core 71.93% <ø> (+0.08%) ⬆️
application-system-api 41.33% <ø> (ø)
application-template-api-modules 27.83% <ø> (ø)
application-templates-accident-notification 29.21% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 26.26% <ø> (ø)
application-templates-driving-license 18.40% <ø> (ø)
application-templates-estate 12.19% <ø> (ø)
application-templates-example-payment 25.17% <ø> (ø)
application-templates-financial-aid 15.56% <ø> (ø)
application-templates-general-petition 23.40% <ø> (ø)
application-templates-inheritance-report 6.52% <ø> (ø)
application-templates-marriage-conditions 15.20% <ø> (ø)
application-templates-mortgage-certificate 43.52% <ø> (ø)
application-templates-parental-leave 29.93% <ø> (ø)
application-types 6.62% <ø> (ø)
application-ui-components 1.27% <ø> (ø)
application-ui-shell 20.87% <ø> (ø)
auth-react 21.94% <ø> (ø)
clients-charge-fjs-v2 24.11% <ø> (ø)
contentful-apps 5.20% <ø> (ø)
financial-aid-backend 51.38% <ø> (ø)
financial-aid-shared 17.81% <ø> (ø)
island-ui-core 28.86% <ø> (ø)
judicial-system-web 27.58% <ø> (ø)
portals-admin-regulations-admin 1.85% <ø> (ø)
portals-core 15.91% <ø> (ø)
services-auth-personal-representative 45.14% <ø> (+0.02%) ⬆️
shared-components 26.93% <ø> (ø)
shared-form-fields 31.22% <ø> (ø)
web 1.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc89848...a76e682. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Oct 31, 2024

Datadog Report

All test runs f76fa4a 🔗

34 Total Test Services: 0 Failed, 32 Passed
⬆️ Test Sessions change in coverage: 1 increased (+0.1%), 148 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-web 0 0 0 2 0 8.02s 1 no change Link
api 0 0 0 4 0 2.9s 1 no change Link
application-api-files 0 0 0 12 0 6.11s 1 no change Link
application-core 0 0 0 97 0 20.7s 1 increased (+0.1%) Link
application-system-api 0 0 0 131 2 3m 25.78s 1 no change Link
application-template-api-modules 0 0 0 123 0 2m 32.69s 1 no change Link
application-templates-accident-notification 0 0 0 148 0 19.61s 1 no change Link
application-templates-criminal-record 0 0 0 2 0 10.89s 1 no change Link
application-templates-driving-license 0 0 0 13 0 16.93s 1 no change Link
application-templates-example-payment 0 0 0 2 0 11.61s 1 no change Link

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Affected services are: api,application-system-api,financial-aid-api,financial-aid-backend,financial-aid-open-api,services-auth-personal-representative,air-discount-scheme-web,consultation-portal,contentful-apps,financial-aid-web-osk,financial-aid-web-veita,judicial-system-web,skilavottord-web,web,application-system-form,island-ui-storybook,portals-admin,service-portal,system-e2e,
Feature deployment of your services will begin shortly. Your feature will be accessible here:
https://my-pageslayout-api-catalogue.dev01.devland.is/api
https://my-pageslayout-application-callback-xrd.internal.dev01.devland.is/application-payment
https://my-pageslayout-application-callback-xrd.internal.dev01.devland.is/applications
https://my-pageslayout-application-payment-callback-xrd.internal.dev01.devland.is/application-payment
https://my-pageslayout-application-payment-callback-xrd.internal.dev01.devland.is/applications
https://my-pageslayout-beta.dev01.devland.is/
https://my-pageslayout-beta.dev01.devland.is/api
https://my-pageslayout-beta.dev01.devland.is/app/skilavottord/
https://my-pageslayout-beta.dev01.devland.is/minarsidur
https://my-pageslayout-beta.dev01.devland.is/samradsgatt
https://my-pageslayout-beta.dev01.devland.is/stjornbord
https://my-pageslayout-beta.dev01.devland.is/stjornbord/bff
https://my-pageslayout-beta.dev01.devland.is/umsoknir
https://my-pageslayout-loftbru-cf.dev01.devland.is/
https://my-pageslayout-loftbru.dev01.devland.is/
https://my-pageslayout-ui.dev01.devland.is/

Deployed services: application-system-api,application-system-form,service-portal,portals-admin,consultation-portal,api,web,skilavottord-web,island-ui-storybook,air-discount-scheme-web,application-system-api-worker,services-bff-portals-admin.
Excluded services: contentful-apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-feature Deploys features to dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant