feat(j-s): Send defenders a notification once assigned to indictment case #16687

unakb · 2024-10-31T15:16:46Z

Email á verjanda þegar hann er samþykktur af dómara

What

Send a notification to a defender when they are assigned to an indictment case by the judge

Why

So they can access the case in the judicial system portal

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

Summary by CodeRabbit

New Features
- Introduced a new DefendantNotificationService for managing notifications related to defendants.
- Added support for sending notifications when an advocate is assigned to a defendant.
- New types for notifications enhance clarity and organization.
Bug Fixes
- Removed unnecessary notification logic for advocate assignments in indictment cases, streamlining the notification process.
Documentation
- Updated message identifiers and templates for improved clarity in notifications.
Style
- Enhanced dynamic text in modal components for better user feedback regarding confirmation states.

coderabbitai · 2024-10-31T15:16:54Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 7adc95a and ace2d8b.

📒 Files selected for processing (14)

apps/judicial-system/backend/src/app/modules/defendant/defendant.service.ts (3 hunks)
apps/judicial-system/backend/src/app/modules/notification/caseNotification.service.ts (0 hunks)
apps/judicial-system/backend/src/app/modules/notification/defendantNotification.service.ts (1 hunks)
apps/judicial-system/backend/src/app/modules/notification/defendantNotification.strings.ts (1 hunks)
apps/judicial-system/backend/src/app/modules/notification/dto/defendantNotification.dto.ts (1 hunks)
apps/judicial-system/backend/src/app/modules/notification/internalNotification.controller.ts (3 hunks)
apps/judicial-system/backend/src/app/modules/notification/notification.module.ts (2 hunks)
apps/judicial-system/web/src/routes/Court/Indictments/Advocates/Advocates.strings.ts (3 hunks)
apps/judicial-system/web/src/routes/Court/Indictments/Advocates/Advocates.tsx (2 hunks)
apps/judicial-system/web/src/routes/Court/Indictments/Advocates/SelectCivilClaimantAdvocate.tsx (1 hunks)
apps/judicial-system/web/src/routes/Court/Indictments/Advocates/SelectDefender.tsx (1 hunks)
libs/judicial-system/message/src/lib/message.ts (2 hunks)
libs/judicial-system/types/src/index.ts (1 hunks)
libs/judicial-system/types/src/lib/notification.ts (1 hunks)

 ________________________________
< Overly attached code reviewer. >
 --------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure languagetool in your project's settings in CodeRabbit enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-10-31T15:35:04Z

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.66%. Comparing base (7adc95a) to head (ace2d8b).

Files with missing lines	Patch %	Lines
...c/routes/Court/Indictments/Advocates/Advocates.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16687      +/-   ##
==========================================
- Coverage   36.67%   36.66%   -0.01%     
==========================================
  Files        6858     6858              
  Lines      142789   142774      -15     
  Branches    40704    40697       -7     
==========================================
- Hits        52364    52352      -12     
+ Misses      90425    90422       -3

Flag	Coverage Δ
api	`3.37% <ø> (ø)`
application-system-api	`41.32% <ø> (ø)`
application-template-api-modules	`27.79% <ø> (+0.01%)`	⬆️
judicial-system-api	`19.59% <100.00%> (+0.07%)`	⬆️
judicial-system-formatters	`79.97% <100.00%> (+0.06%)`	⬆️
judicial-system-message	`67.43% <100.00%> (+0.06%)`	⬆️
judicial-system-message-handler	`48.62% <100.00%> (+0.08%)`	⬆️
judicial-system-scheduler	`70.72% <100.00%> (+0.09%)`	⬆️
judicial-system-types	`43.92% <0.00%> (-0.21%)`	⬇️
judicial-system-web	`27.66% <0.00%> (+<0.01%)`	⬆️
skilavottord-ws	`24.14% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...end/src/app/modules/defendant/defendant.service.ts	`80.00% <ø> (-1.61%)`	⬇️
...p/modules/notification/caseNotification.service.ts	`81.40% <ø> (-0.19%)`	⬇️
...es/notification/internalNotification.controller.ts	`95.45% <ø> (-0.11%)`	⬇️
...rc/app/modules/notification/notification.module.ts	`0.00% <ø> (ø)`
...s/Court/Indictments/Advocates/Advocates.strings.ts	`0.00% <ø> (ø)`
...ictments/Advocates/SelectCivilClaimantAdvocate.tsx	`0.00% <ø> (ø)`
...tes/Court/Indictments/Advocates/SelectDefender.tsx	`0.00% <ø> (ø)`
libs/judicial-system/message/src/lib/message.ts	`100.00% <100.00%> (ø)`
libs/judicial-system/types/src/index.ts	`100.00% <100.00%> (ø)`
libs/judicial-system/types/src/lib/notification.ts	`100.00% <100.00%> (ø)`
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7adc95a...ace2d8b. Read the comment docs.

datadog-island-is · 2024-10-31T15:37:16Z

Datadog Report

All test runs 3d42d95 🔗

❌ 13 Total Test Services: 1 Failed, 12 Passed
🔻 Test Sessions change in coverage: 2 decreased, 8 increased, 8 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
`judicial-system-backend`	4	21152	0	15m 57.93s	1 decreased (-0.08%)	Link
`api`	0	4	0	2.38s	1 no change	Link
`application-system-api`	0	120	2	3m 17.11s	1 no change	Link
`application-template-api-modules`	0	123	0	2m 2.59s	1 increased (+0.01%)	Link
`judicial-system-api`	0	58	0	6.1s	1 increased (+0.08%)	Link
`judicial-system-formatters`	0	38	0	5.1s	1 increased (+0.05%)	Link
`judicial-system-message`	0	35	0	11.23s	1 increased (+0.07%)	Link
`judicial-system-message-handler`	0	4	0	3.45s	1 increased (+0.1%)	Link
`judicial-system-scheduler`	0	4	0	3.64s	1 increased (+0.09%)	Link
`judicial-system-types`	0	23	0	5.85s	1 decreased (-0.24%)	Link

❌ Failed Tests (4)

InternalNotificationController - Send defender assigned notifications record notification should record notification - apps/judicial-system/backend/src/app/modules/notification/test/internalNotificationController/sendAdvocateAssignedNotifications.spec.ts - Details
Expand for error
```
 expect(jest.fn()).toHaveBeenCalledTimes(expected)
 
 Expected number of calls: 1
 Received number of calls: 0
```
InternalNotificationController - Send defender assigned notifications should only send one email to each defender should return notification was sent - apps/judicial-system/backend/src/app/modules/notification/test/internalNotificationController/sendAdvocateAssignedNotifications.spec.ts - Details
Expand for error
```
 expect(jest.fn()).toHaveBeenCalled()
 
 Expected number of calls: >= 1
 Received number of calls:    0
```
InternalNotificationController - Send defender assigned notifications should send email to every defender should return notification was sent - apps/judicial-system/backend/src/app/modules/notification/test/internalNotificationController/sendAdvocateAssignedNotifications.spec.ts - Details
Expand for error
```
 expect(jest.fn()).toHaveBeenCalled()
 
 Expected number of calls: >= 1
 Received number of calls:    0
```
InternalNotificationController - Send defender assigned notifications when sending defender assigned notifications should send correct email - apps/judicial-system/backend/src/app/modules/notification/test/internalNotificationController/sendAdvocateAssignedNotifications.spec.ts - Details
Expand for error
```
 expect(jest.fn()).toHaveBeenCalledTimes(expected)
 
 Expected number of calls: 1
 Received number of calls: 0
```

🔻 Code Coverage Decreases vs Default Branch (2)

judicial-system-types - jest 47.04% (-0.24%) - Details
judicial-system-backend - jest 58.67% (-0.08%) - Details

unakb added 4 commits October 30, 2024 15:36

feat(j-s): Handle advocate assigned to defendant notification

286cfcc

Merge branch 'main' into j-s/defender-assigned-indictment-notification

75105f3

Update defendant.service.ts

de44e03

Update defendantNotification.service.ts

218a8b3

unakb added 2 commits October 31, 2024 15:36

fix(j-s): Small fix on modal texts

dbb29bf

Merge branch 'main' into j-s/defender-assigned-indictment-notification

ace2d8b

unakb marked this pull request as ready for review October 31, 2024 15:39

unakb requested a review from a team as a code owner October 31, 2024 15:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(j-s): Send defenders a notification once assigned to indictment case #16687

feat(j-s): Send defenders a notification once assigned to indictment case #16687

unakb commented Oct 31, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 31, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Oct 31, 2024 •

edited

Loading

datadog-island-is bot commented Oct 31, 2024 •

edited

Loading

feat(j-s): Send defenders a notification once assigned to indictment case #16687

Are you sure you want to change the base?

feat(j-s): Send defenders a notification once assigned to indictment case #16687

Conversation

unakb commented Oct 31, 2024 • edited by coderabbitai bot Loading

What

Why

Checklist:

Summary by CodeRabbit

coderabbitai bot commented Oct 31, 2024 • edited Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Oct 31, 2024 • edited Loading

Codecov Report

datadog-island-is bot commented Oct 31, 2024 • edited Loading

Datadog Report

❌ Failed Tests (4)

🔻 Code Coverage Decreases vs Default Branch (2)

unakb commented Oct 31, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 31, 2024 •

edited

Loading

codecov bot commented Oct 31, 2024 •

edited

Loading

datadog-island-is bot commented Oct 31, 2024 •

edited

Loading