chore(search-indexer-service): Change prod url #16689
Conversation
WalkthroughThe changes in this pull request involve updates to the ingress configuration in both the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (1)charts/islandis/values.prod.yaml (1)
The change to use Let's verify the URL pattern consistency across other services: ✅ Verification successfulURL pattern follows established conventions Based on the verification results, the URL pattern
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if other services follow the same URL pattern in production
# Expected: Most internal services should use the .island.is domain
rg -A 1 'host:.*\.island\.is' --no-filename | sort -u
Length of output: 1245 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
apps/services/search-indexer/infra/search-indexer-service.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/services/search-indexer/infra/search-indexer-service.ts (2)
Pattern apps/services/**/*: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (2)
apps/services/search-indexer/infra/search-indexer-service.ts (2)
Line range hint 119-133: Ensure CMS webhook configuration is updated.
The ingress configuration change looks correct, but as mentioned in the PR objectives, don't forget to:
- Update the webhook URL in the CMS during the next release
- Coordinate with DevOps team to ensure proper routing is configured
Would you like me to create a GitHub issue to track the CMS webhook update task?
Line range hint 123-133: Confirm security configuration for production environment.
The security configuration looks appropriate:
- Global auth is explicitly disabled for dev/staging
- Production maintains stricter security with no auth override
Change prod url
What
Slack discussion: https://islandis.slack.com/archives/C019LNRM6LE/p1730371957246189
https://islandis.slack.com/archives/C04R5PKH8TZ/p1730370825455869
I'll be responsible for changing the webhook url in the cms when the next release goes out
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation