Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dcorelib when triqs is not installed #149

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Conversation

yomichi
Copy link
Contributor

@yomichi yomichi commented Sep 13, 2024

When TRIQS is not installed, dcorelib.triqs_compat will be used.
If you want to use dcorelib.triqs_compat when TRIQS is installed, set an environment variable DCORE_TRIQS_COMPAT=1

By default, use dcorelib.triqs_compat.
If you want to use TRIQS library, set an environment variable DCORE_TRIQS_COMPAT=0 explicitely.

@shinaoka
Copy link
Contributor

shinaoka commented Sep 13, 2024

We could remove the TRIQS detection, which may cause unexpected behavior (e.g., picking up an incompatible TRIQS version).

@yomichi
Copy link
Contributor Author

yomichi commented Sep 13, 2024

OK, I changed to that to import triqs only when DCORE_TRIQS_COMPAT=0 is explicitly set, and I added a version check of imported TRIQS.

@yomichi yomichi merged commit b2a8b5e into develop Sep 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants