Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interface for getting configurations #295

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

nirvanagit
Copy link
Collaborator

Description

What does this change do and why?
Adds an interface for fetching configurations for a given identity, or all the identities in a given cluister.

admiral/pkg/registry/registry.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.47%. Comparing base (f496b69) to head (24cb0b5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   73.38%   73.47%   +0.08%     
==========================================
  Files          35       35              
  Lines        3664     3638      -26     
==========================================
- Hits         2689     2673      -16     
+ Misses        803      797       -6     
+ Partials      172      168       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vrushalijoshi vrushalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@nirvanagit nirvanagit merged commit 6f1cd09 into master May 17, 2024
4 checks passed
@nirvanagit nirvanagit deleted the configuration-interface branch May 17, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants