Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream refresh #308

Closed
wants to merge 240 commits into from
Closed

Upstream refresh #308

wants to merge 240 commits into from

Conversation

nirvanagit
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 65.50336% with 514 lines in your changes missing coverage. Please review.

Project coverage is 71.04%. Comparing base (81e4462) to head (e004461).

Files Patch % Lines
admiral/pkg/clusters/dynamoDB.go 16.15% 188 Missing and 4 partials ⚠️
admiral/pkg/clusters/admiralDatabaseClient.go 8.33% 44 Missing ⚠️
admiral/pkg/clusters/destinationrule_handler.go 88.31% 27 Missing and 16 partials ⚠️
.../pkg/clusters/admiralReadWriteLeaseStateChecker.go 58.44% 31 Missing and 1 partial ⚠️
...ral/pkg/clusters/clientconnectionconfig_handler.go 57.53% 30 Missing and 1 partial ⚠️
admiral/pkg/clusters/dependency_handler.go 77.69% 22 Missing and 7 partials ⚠️
admiral/pkg/apis/admiral/routes/handlers.go 64.61% 19 Missing and 4 partials ⚠️
admiral/pkg/clusters/outlierdetection_handler.go 62.71% 20 Missing and 2 partials ⚠️
.../pkg/clusters/admiralIgnoreIdentityStateChecker.go 78.35% 14 Missing and 7 partials ⚠️
admiral/pkg/clusters/globaltraffic_handler.go 61.53% 19 Missing and 1 partial ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   73.37%   71.04%   -2.34%     
==========================================
  Files          35       58      +23     
  Lines        3670     7994    +4324     
==========================================
+ Hits         2693     5679    +2986     
- Misses        804     2034    +1230     
- Partials      173      281     +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nirvanagit nirvanagit marked this pull request as ready for review August 3, 2024 00:46
@nirvanagit nirvanagit closed this Aug 3, 2024
@shriramsharma shriramsharma deleted the upstream-refresh branch August 9, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants