Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream refresh fix #309

Merged
merged 31 commits into from
Aug 3, 2024
Merged

Upstream refresh fix #309

merged 31 commits into from
Aug 3, 2024

Conversation

nirvanagit
Copy link
Collaborator

No description provided.

@nirvanagit nirvanagit marked this pull request as ready for review August 3, 2024 00:36
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 39.25049% with 308 lines in your changes missing coverage. Please review.

Please upload report for BASE (upstream-refresh@6a9b7cb). Learn more about missing BASE report.

Files Patch % Lines
admiral/pkg/clusters/dynamoDB.go 16.15% 188 Missing and 4 partials ⚠️
admiral/pkg/clusters/admiralDatabaseClient.go 8.33% 44 Missing ⚠️
.../pkg/clusters/admiralReadWriteLeaseStateChecker.go 58.44% 31 Missing and 1 partial ⚠️
.../pkg/clusters/admiralIgnoreIdentityStateChecker.go 78.35% 14 Missing and 7 partials ⚠️
admiral/pkg/clusters/admiralStateChecker.go 60.00% 10 Missing and 2 partials ⚠️
admiral/pkg/controller/secret/secretcontroller.go 73.07% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             upstream-refresh     #309   +/-   ##
===================================================
  Coverage                    ?   71.04%           
===================================================
  Files                       ?       58           
  Lines                       ?     7994           
  Branches                    ?        0           
===================================================
  Hits                        ?     5679           
  Misses                      ?     2034           
  Partials                    ?      281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nirvanagit nirvanagit merged commit e004461 into upstream-refresh Aug 3, 2024
1 check passed
@nirvanagit nirvanagit deleted the upstream-refresh-fix branch August 3, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants