Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build configurations for state syncer #314

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

rtay1188
Copy link
Collaborator

Co-authored-by: nirvanagit [email protected]
Co-authored-by: Ryan Tay [email protected]

statesyncer changes

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

What does this change do and why?

[Link to related ISSUE]

Thank you!

@rtay1188 rtay1188 changed the title [MESH-5162] - build configurations for state syncer (#730) build configurations for state syncer Aug 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 65.94912% with 174 lines in your changes missing coverage. Please review.

Project coverage is 71.75%. Comparing base (0e7d8fe) to head (f8d3e69).

Files Patch % Lines
admiral/pkg/clusters/serviceentry.go 70.39% 44 Missing and 9 partials ⚠️
admiral/pkg/registry/configSyncer.go 0.00% 46 Missing ⚠️
admiral/pkg/registry/configWriter.go 40.00% 25 Missing and 2 partials ⚠️
admiral/pkg/controller/common/common.go 71.42% 9 Missing and 5 partials ⚠️
admiral/pkg/clusters/configSyncer.go 84.44% 4 Missing and 3 partials ⚠️
admiral/pkg/registry/config.go 0.00% 6 Missing ⚠️
admiral/pkg/clusters/util.go 73.68% 5 Missing ⚠️
admiral/pkg/registry/rolloutConfig_parser.go 0.00% 5 Missing ⚠️
admiral/pkg/controller/util/util.go 0.00% 4 Missing ⚠️
admiral/pkg/registry/configCache.go 88.88% 2 Missing and 2 partials ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   72.33%   71.75%   -0.59%     
==========================================
  Files          61       65       +4     
  Lines        8349     8641     +292     
==========================================
+ Hits         6039     6200     +161     
- Misses       2011     2128     +117     
- Partials      299      313      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aaeron and others added 2 commits August 12, 2024 13:47
Co-authored-by: nirvanagit <[email protected]>
Co-authored-by: Ryan Tay <[email protected]>

statesyncer changes

Signed-off-by: Ryan Tay <[email protected]>
Signed-off-by: Ryan Tay <[email protected]>
Signed-off-by: Ryan Tay <[email protected]>
Copy link
Collaborator

@nirvanagit nirvanagit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rtay1188 !!

@nirvanagit nirvanagit merged commit 0aea582 into istio-ecosystem:master Aug 13, 2024
3 checks passed
@rtay1188 rtay1188 deleted the statesyncer branch August 14, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants