Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client (mesh egress) discovery for Jobs and Numaflow (vertices and monovertices) #339

Merged
merged 28 commits into from
Oct 9, 2024

Conversation

aattuluri
Copy link
Contributor

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

What does this change do and why?
This change introduces client discovery where there is no ingress but only mesh egress required like k8s Jobs, numaflow Vertices and Monovertices.

[Link to related ISSUE]

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 77.93103% with 128 lines in your changes missing coverage. Please review.

Project coverage is 63.73%. Comparing base (323801a) to head (72623ae).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
admiral/pkg/controller/admiral/job.go 80.40% 24 Missing and 5 partials ⚠️
admiral/pkg/controller/admiral/monovertex.go 83.00% 22 Missing and 4 partials ⚠️
admiral/pkg/controller/admiral/vertex.go 83.55% 21 Missing and 4 partials ⚠️
admiral/pkg/clusters/clientdiscovery_handler.go 42.85% 23 Missing and 1 partial ⚠️
admiral/pkg/clusters/handler.go 18.75% 13 Missing ⚠️
admiral/pkg/clusters/registry.go 60.00% 5 Missing and 3 partials ⚠️
admiral/cmd/admiral/cmd/root.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   71.75%   63.73%   -8.03%     
==========================================
  Files          66       91      +25     
  Lines        9446    11926    +2480     
==========================================
+ Hits         6778     7601     +823     
- Misses       2295     3911    +1616     
- Partials      373      414      +41     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

admiral/pkg/controller/admiral/controller.go Outdated Show resolved Hide resolved
admiral/pkg/controller/admiral/job.go Outdated Show resolved Hide resolved
admiral/pkg/controller/common/common.go Show resolved Hide resolved
admiral/pkg/controller/admiral/job.go Outdated Show resolved Hide resolved
admiral/pkg/controller/admiral/monovertex.go Outdated Show resolved Hide resolved
admiral/pkg/client/loader/kube_loader.go Show resolved Hide resolved
admiral/pkg/clusters/handler.go Outdated Show resolved Hide resolved
admiral/pkg/controller/admiral/vertex.go Outdated Show resolved Hide resolved
admiral/pkg/controller/admiral/vertex.go Outdated Show resolved Hide resolved
admiral/pkg/controller/admiral/job.go Outdated Show resolved Hide resolved
@aattuluri aattuluri force-pushed the Seperate-out-service-and-client-discovery branch from dc1a35b to 22e695e Compare September 25, 2024 22:10
@aattuluri aattuluri changed the title WIP - Client (mesh egress) discovery for Jobs and Numaflow (vertices and monovertices) Client (mesh egress) discovery for Jobs and Numaflow (vertices and monovertices) Sep 30, 2024
tests/install_istio.sh Outdated Show resolved Hide resolved
install/sample/sample_dep.yaml Outdated Show resolved Hide resolved
admiral/pkg/clusters/dependency_handler.go Show resolved Hide resolved
admiral/pkg/controller/admiral/job.go Outdated Show resolved Hide resolved
@aattuluri aattuluri merged commit fd81dfe into master Oct 9, 2024
3 checks passed
@aattuluri aattuluri deleted the Seperate-out-service-and-client-discovery branch October 9, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants