-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client (mesh egress) discovery for Jobs and Numaflow (vertices and monovertices) #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
==========================================
- Coverage 71.75% 63.73% -8.03%
==========================================
Files 66 91 +25
Lines 9446 11926 +2480
==========================================
+ Hits 6778 7601 +823
- Misses 2295 3911 +1616
- Partials 373 414 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kpharasi
reviewed
Sep 11, 2024
aattuluri
force-pushed
the
Seperate-out-service-and-client-discovery
branch
from
September 25, 2024 22:10
dc1a35b
to
22e695e
Compare
aattuluri
changed the title
WIP - Client (mesh egress) discovery for Jobs and Numaflow (vertices and monovertices)
Client (mesh egress) discovery for Jobs and Numaflow (vertices and monovertices)
Sep 30, 2024
kpharasi
reviewed
Oct 9, 2024
kpharasi
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
🚨 Please review this repository's contribution guidelines.
Description
What does this change do and why?
This change introduces client discovery where there is no ingress but only mesh egress required like k8s Jobs, numaflow Vertices and Monovertices.
[Link to related ISSUE]
Thank you!