Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MESH-5515] Add 'security.istio.io/tlsMode' label to SE endpoints for deployment to rollout migration usecase #343

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

Punakshi
Copy link
Collaborator

  • Updated various test cases to include the 'security.istio.io/tlsMode' label in Service Entries and Workload Entries.
  • Modified validation logic to check for the presence of the 'security.istio.io/tlsMode' label.
  • Refactored code to ensure the 'security.istio.io/tlsMode' label is added where necessary.
  • Enhanced error handling in validation functions to provide detailed error messages.

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

What does this change do and why?

[Link to related ISSUE]

Thank you!

```
[MESH-5515] Add 'security.istio.io/tlsMode' label to Service Entries and Workload Entries during deployment to rollout migration usecase

- Updated various test cases to include the 'security.istio.io/tlsMode' label in Service Entries and Workload Entries.
- Modified validation logic to check for the presence of the 'security.istio.io/tlsMode' label.
- Refactored code to ensure the 'security.istio.io/tlsMode' label is added where necessary.
- Enhanced error handling in validation functions to provide detailed error messages.
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.72%. Comparing base (4b33279) to head (eb9ceec).

Files with missing lines Patch % Lines
admiral/pkg/clusters/serviceentry.go 76.92% 2 Missing and 1 partial ⚠️
admiral/pkg/clusters/configwriter.go 33.33% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   71.72%   71.72%   -0.01%     
==========================================
  Files          66       66              
  Lines        9241     9248       +7     
==========================================
+ Hits         6628     6633       +5     
- Misses       2254     2255       +1     
- Partials      359      360       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

```
[MESH-5515] Rename validateServiceEntry to validateServiceEntryEndpoints
@Punakshi Punakshi merged commit 61e7c3f into master Sep 14, 2024
3 checks passed
@Punakshi Punakshi deleted the MESH-5515-DeploymentToRolloutFix branch September 14, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants