Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command stringarr toslice #353

Conversation

shriramsharma
Copy link
Collaborator

Fix command stringarr toslice

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.75%. Comparing base (bb03713) to head (2a02ca6).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
admiral/pkg/clusters/serviceentry.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   71.75%   71.75%           
=======================================
  Files          66       66           
  Lines        9446     9446           
=======================================
  Hits         6778     6778           
  Misses       2295     2295           
  Partials      373      373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shriram Sharma <[email protected]>
@shriramsharma shriramsharma merged commit 182ccab into istio-ecosystem:master Oct 4, 2024
3 checks passed
@shriramsharma shriramsharma deleted the fix-command-stringarr-toslice branch October 4, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants