Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe check Metadata existence, change to slicevar #356

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

aattuluri
Copy link
Contributor

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

What does this change do and why?

[Link to related ISSUE]

Thank you!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.72%. Comparing base (98cd9e3) to head (5403e50).

Files with missing lines Patch % Lines
admiral/cmd/admiral/cmd/root.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   63.72%   63.72%           
=======================================
  Files          91       91           
  Lines       11922    11922           
=======================================
  Hits         7597     7597           
  Misses       3911     3911           
  Partials      414      414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aattuluri aattuluri merged commit eb58c1d into master Nov 6, 2024
3 checks passed
@aattuluri aattuluri deleted the Fix-data-issue-with-numaflow-objects branch November 6, 2024 19:52
@aattuluri aattuluri restored the Fix-data-issue-with-numaflow-objects branch November 6, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants