Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to gateway documentation to clarify use of non-standard ports. #2732

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhuttley-F5-com
Copy link

This attempt is generated from the gateway.proto files.
did make gen

This is generated from the gateway.proto  files
@jhuttley-F5-com jhuttley-F5-com requested a review from a team as a code owner March 16, 2023 23:25
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Mar 16, 2023
@istio-testing
Copy link
Collaborator

Hi @jhuttley-F5-com. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericvn
Copy link

ericvn commented Mar 17, 2023

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 17, 2023
@@ -35,6 +35,12 @@ import "google/api/field_behavior.proto";
// on these ports, it is the responsibility of the user to ensure that
// external traffic to these ports are allowed into the mesh.
//
// Ports 9443 and 2379 must exist on the ingress-gateway, `my-gateway-controller` in the example below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not mention 9080?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which I saw also in the gateway example below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, yes there could be more, but at the moment I'm trying to figure out how the process works. it says I need to apply a release-notes-none label and I haven't figure out how to do that!!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @linsun I cant figure out how to edit this PR to add the release-notes-none label. In addition I set it to "draft" and now see no way to remove that label in the webpage.
https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels#applying-a-label
Does not seem to help as in my own fork, I don't see my PR.

Using gh I dont have access.

? Which repository should be the default? istio/api
✓ Set istio/api as the default repository for the current directory
gh pr list
gh pr edit
? What would you like to edit? Labels
? Labels do-not-merge/work-in-progress, ok-to-test, release-notes-none, size/M
? Submit? Yes
Message: jhuttley-F5-com does not have the correct permissions to execute AddLabelsToLabelable, Locations: [{Line:1 Column:54}]

Do I have to cancel the PR and start again? --John

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, yes there could be more, but at the moment I'm trying to figure out how the process works. it says I need to apply a release-notes-none label and I haven't figure out how to do that!!

I believe only istio members, and maybe its maintainers, can apply the label. A secondary comment is if you look closely, the release-notes_api test is not required in this repo. As such, a failure in that test would not prevent a PR from being merged.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Since this change is clarifying documentation and that usually doesn't have a release note, I'll add the release-noes-none label.

@jhuttley-F5-com jhuttley-F5-com marked this pull request as draft March 23, 2023 21:10
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 23, 2023
@ericvn ericvn added the release-notes-none Indicates a PR that does not require release notes. label Mar 24, 2023
@jhuttley-F5-com jhuttley-F5-com marked this pull request as ready for review March 31, 2023 21:14
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 31, 2023
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 6, 2024
@istio-testing
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR needs to be rebased before being merged ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants