Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Add note on DR workloadSelector #3088

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Doc: Add note on DR workloadSelector #3088

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c487e7b
Add note on DR workloadSelector
NaturezzZ Feb 15, 2024
5dae24c
polish and remove comparison with SE
NaturezzZ Feb 17, 2024
8b4cd8e
fix wording to eliminate ambiguity
NaturezzZ Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions networking/v1alpha3/destination_rule.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions networking/v1alpha3/destination_rule.pb.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions networking/v1alpha3/destination_rule.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,12 @@ import "type/v1beta1/selector.proto";
// The following example shows how a destination rule can be applied to a
// specific workload using the workloadSelector configuration.
//
// **Note:** The workloadSelector configuration in
// Destination Rules reveals which workloads the traffic emanating from
NaturezzZ marked this conversation as resolved.
Show resolved Hide resolved
// uses this Destination Rule, unlike the workloadSelector configuration
NaturezzZ marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to compare with SE here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or why it is SE not other API that contains workloadSelector. IMO we donot have to do such explicit comparation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed and changed a better counter example in latest commit. thank you.

// in [ServiceEntries](https://istio.io/docs/reference/config/networking/service-entry/#ServiceEntry),
NaturezzZ marked this conversation as resolved.
Show resolved Hide resolved
// which is used to reveal which workloads the traffic is routed to.
NaturezzZ marked this conversation as resolved.
Show resolved Hide resolved
//
// {{<tabset category-name="selector-example">}}
// {{<tab name="v1alpha3" category-value="v1alpha3">}}
// ```yaml
Expand Down