Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: add documentation and use CEL pre-processor #3333

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

howardjohn
Copy link
Member

Depends on istio/tools#3050.

This PR adds support for a new cel pre-processor: https://github.com/howardjohn/celpp.

This avoids the need to write incredibly verbose and error prone boilerplate to workaround limitations in the CEL language.


This PR has a few commits:

  • Run with no changes. The pre-processor formats the CEL expression, so this has some trivial changes
  • Incrementally migrate things to the new CEL macros where it makes sense to simplify
  • Add documentation for validation (includes more than just the new stuff)

@howardjohn howardjohn added the do-not-merge/hold Block automatic merging of a PR. label Oct 10, 2024
@howardjohn howardjohn requested review from a team as code owners October 10, 2024 21:10
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 10, 2024
@istio-testing
Copy link
Collaborator

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
gencheck_api 584cc10 link true /test gencheck
release-notes_api 584cc10 link false /test release-notes
build_api 584cc10 link true /test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Block automatic merging of a PR. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants