This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Return error to reconciler when process manifest fails #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
morvencao
reviewed
Dec 5, 2019
There was a problem hiding this comment.
not sure if this makes sense.
Once these errors are returned to the main reconcile loop, the controller will re-trigger new reconcile loop.
However, some kinds of manifest process errors will emerge, no matter how many times the reconcile loop are triggerred, in these cases, we'd better keep the process in the ICP status.
ostromart
reviewed
Dec 11, 2019
| @@ -115,7 +116,11 @@ func (h *HelmReconciler) Reconcile() error { | |||
| errs = util.AppendErr(errs, h.customizer.Listener().EndPrune()) | |||
|
|
|||
| errs = util.AppendErr(errs, h.customizer.Listener().EndReconcile(h.instance, status)) | |||
|
|
|||
| for _, v := range status.Status { | |||
| if v.Error != "" { | |||
There was a problem hiding this comment.
It would be better to check against the enum status field (!=ERROR).
|
@irisdingbj: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
istio-testing
added
the
needs-rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
istio/istio#19125