Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new QNativeIpcKey based QSharedMemory constructor with Qt 6.6 and higher #177

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

jonaski
Copy link
Collaborator

@jonaski jonaski commented Sep 28, 2023

Switch to the new QNativeIpcKey based QSharedMemory constructor with Qt 6.6 and higher, the old constructor will be deprecated. This also makes the library work again with the upcoming Qt 6.6 release and higher. However, there are still issues with releasing the existing memory in cases where the application is forcefully quit or crashed.

… higher

Switch to the new QNativeIpcKey based QSharedMemory constructor with Qt 6.6 and higher, the old constructor will be deprecated.
This also makes the library work again with the upcoming Qt 6.6 release and higher.
However, there are still issues with releasing the existing memory in cases where the application is forcefully quit or crashed.
@jonaski
Copy link
Collaborator Author

jonaski commented Sep 28, 2023

Shatur
Shatur previously approved these changes Sep 28, 2023
@itay-grudev
Copy link
Owner

That's amazing - thanks!

In the mean time I continue working on a rewrite using local sockets only.

@itay-grudev
Copy link
Owner

I'm releasing this patch as v3.5.0 as the change may be tiny, but the consequences - significant.

@itay-grudev itay-grudev merged commit c6519b6 into itay-grudev:master Sep 28, 2023
9 checks passed
@jonaski jonaski deleted the qnativeipckey branch September 28, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants