Change paths to inference launchers #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix flake8 test
…mes, fix some issues
Refactoring: fix pep issues and so
Co-authored-by: valentina-kustikova <valentina.kustikova.gmail.com> Co-authored-by: Vasiliev Evgenii <[email protected]> Co-authored-by: Valentina <[email protected]>
|
This pull request contribute changes from our fork with upstream. After that, we want to add all our changes to upstream repository and have an open dialog on changes. |
|
@FenixFly @valentina-kustikova please review |
valentina-kustikova
requested review from
valentina-kustikova,
a-sidorova and
FenixFly
FenixFly
previously approved these changes
Oct 10, 2022
a-sidorova
reviewed
Oct 10, 2022
valentina-kustikova
dismissed
FenixFly’s stale review
@FenixFly, скорее всего будет проблема со статическими путями, мы обсуждали тот вопрос с Александрой в прошлом семестре и повесили таску.
|
@valentina-kustikova Please review updated code |
a-sidorova
approved these changes
Oct 13, 2022
FenixFly
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps it is worth removing the dependency on 'tmp/dl-benchmark' in the code? Hardcode paths are not welcome