add exit codes

ivy-llc · Aug 25, 2023 · a484dec · a484dec
1 parent 92a98ca
commit a484dec
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/test_basics.yml b/.github/workflows/test_basics.yml
@@ -12,7 +12,7 @@ jobs:
   platform:
     strategy:
       matrix:
-        os: [ubuntu-20.04, windows-latest, macos-latest]
+        os: [ubuntu-latest, windows-latest, macos-latest]
 
     runs-on: ${{ matrix.os }}
     steps:
@@ -43,6 +43,7 @@ jobs:
         run: |
           cd demos
           docker run -v `pwd`:/ivy/demos unifyai/ivy:latest demos/tests/test_demos.sh ${{ secrets.USER_API_KEY }} ${{ matrix.modules }}.ipynb "basics"
+        continue-on-error: true
 
   results:
     needs: run-tests

diff --git a/tests/notebook_testing.py b/tests/notebook_testing.py
@@ -158,6 +158,7 @@ def run_cell(shell, iopub, cell, kc):
 def test_notebook(nb):
     km = KernelManager()
     km.start_kernel(extra_arguments=["--pylab=inline"], stderr=open(os.devnull, "w"))
+    exit_code = 0
     try:
         kc = km.client()
         kc.start_channels()
@@ -214,6 +215,7 @@ def test_notebook(nb):
                 failed = True
         if failed:
             failures += 1
+            exit_code = 1
         else:
             successes += 1
         sys.stdout.write(".")
@@ -227,6 +229,7 @@ def test_notebook(nb):
     kc.stop_channels()
     km.shutdown_kernel()
     del km
+    exit(exit_code)
 
 
 if __name__ == "__main__":