-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
62 verify related fields #68
Conversation
Coverage Report
|
Coverage Report
|
Coverage Report
|
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 1a5ebd5 | Previous: 9529491 | Ratio |
---|---|---|---|
edtf/natlang/tests.py::test_benchmark_natlang[23rd Dynasty-None] |
70908.05993591757 iter/sec (stddev: 9.336401373974975e-7 ) |
69470.30558312619 iter/sec (stddev: 8.902008998970827e-7 ) |
0.98 |
edtf/natlang/tests.py::test_benchmark_natlang[January 2008-2008-01] |
8081.312658856538 iter/sec (stddev: 0.000007619156669014199 ) |
8324.483693962113 iter/sec (stddev: 0.000005991359125301758 ) |
1.03 |
edtf/natlang/tests.py::test_benchmark_natlang[ca1860-1860~] |
9656.201214299597 iter/sec (stddev: 0.0000058122713925155625 ) |
9717.911445770509 iter/sec (stddev: 0.00001721606231510305 ) |
1.01 |
edtf/natlang/tests.py::test_benchmark_natlang[uncertain: approx 1862-1862%] |
6652.449123393891 iter/sec (stddev: 0.000006904746593308474 ) |
6822.616414423156 iter/sec (stddev: 0.000008709373046464409 ) |
1.03 |
edtf/natlang/tests.py::test_benchmark_natlang[January-XXXX-01] |
11498.54538461711 iter/sec (stddev: 0.00000493408016541802 ) |
11776.525563412784 iter/sec (stddev: 0.000006066431715301031 ) |
1.02 |
edtf/natlang/tests.py::test_benchmark_natlang[Winter 1872-1872-24] |
8370.392302524268 iter/sec (stddev: 0.00000553850252740975 ) |
8520.893668185601 iter/sec (stddev: 0.000005729463127209827 ) |
1.02 |
edtf/natlang/tests.py::test_benchmark_natlang[before approx January 18 1928-/1928-01-18~] |
5682.908434183922 iter/sec (stddev: 0.000007648465545337454 ) |
5689.570069738053 iter/sec (stddev: 0.000009183288579123991 ) |
1.00 |
edtf/natlang/tests.py::test_benchmark_natlang[birthday in 1872-1872] |
7211.885201598034 iter/sec (stddev: 0.000011366674332750247 ) |
7416.340178119332 iter/sec (stddev: 0.0000065048393546042904 ) |
1.03 |
edtf/natlang/tests.py::test_benchmark_natlang[1270 CE-1270] |
49807.41416902325 iter/sec (stddev: 0.0000014962297096935839 ) |
51164.57645435527 iter/sec (stddev: 0.000001591067852670383 ) |
1.03 |
edtf/natlang/tests.py::test_benchmark_natlang[2nd century bce--01XX] |
44095.45879572501 iter/sec (stddev: 0.0000015617715863917242 ) |
44996.8496097705 iter/sec (stddev: 0.0000015738948584567202 ) |
1.02 |
edtf/natlang/tests.py::test_benchmark_natlang[1858/1860-[1858, 1860]] |
21807.319599248884 iter/sec (stddev: 0.000002798861518096165 ) |
22144.988916227463 iter/sec (stddev: 0.0000037402949863596445 ) |
1.02 |
edtf/parser/tests.py::test_benchmark_parser[2001-02-03] |
124.01091520648583 iter/sec (stddev: 0.0006448552256745901 ) |
125.12658851673503 iter/sec (stddev: 0.0005927338231648203 ) |
1.01 |
edtf/parser/tests.py::test_benchmark_parser[2008-12] |
128.36248456288072 iter/sec (stddev: 0.0028400206829592386 ) |
131.2769148354411 iter/sec (stddev: 0.0020734015216580088 ) |
1.02 |
edtf/parser/tests.py::test_benchmark_parser[2008] |
161.03773548946023 iter/sec (stddev: 0.0016489937904663149 ) |
162.20932109809524 iter/sec (stddev: 0.0014420585113181126 ) |
1.01 |
edtf/parser/tests.py::test_benchmark_parser[-0999] |
159.3818083252433 iter/sec (stddev: 0.002639994681455629 ) |
159.50057446999088 iter/sec (stddev: 0.0020867593024949714 ) |
1.00 |
edtf/parser/tests.py::test_benchmark_parser[2004-01-01T10:10:10+05:00] |
106.31511465424398 iter/sec (stddev: 0.002716914997564173 ) |
113.03387093388542 iter/sec (stddev: 0.0005962281406209244 ) |
1.06 |
edtf/parser/tests.py::test_benchmark_parser[-2005/-1999-02] |
87.04773799144041 iter/sec (stddev: 0.0027618461789397355 ) |
87.53957873255497 iter/sec (stddev: 0.0023153269130372464 ) |
1.01 |
edtf/parser/tests.py::test_benchmark_parser[/2006] |
212.47132987123555 iter/sec (stddev: 0.000154256817795709 ) |
206.53492897715108 iter/sec (stddev: 0.001222742962075483 ) |
0.97 |
edtf/parser/tests.py::test_benchmark_parser[?2004-%06] |
163.0027497205315 iter/sec (stddev: 0.0018175537934075712 ) |
172.0683210752796 iter/sec (stddev: 0.00028320710690097305 ) |
1.06 |
edtf/parser/tests.py::test_benchmark_parser[[1667, 1760-12]] |
18.16706819138367 iter/sec (stddev: 0.0006011220180233923 ) |
18.046458654990015 iter/sec (stddev: 0.002266747315036186 ) |
0.99 |
edtf/parser/tests.py::test_benchmark_parser[Y3388E2S3] |
326.9720390767507 iter/sec (stddev: 0.00033695307092477844 ) |
333.3482802875758 iter/sec (stddev: 0.0010104680755753123 ) |
1.02 |
edtf/parser/tests.py::test_benchmark_parser[2001-29] |
90.18575123804419 iter/sec (stddev: 0.0038441798996662548 ) |
94.51995837255105 iter/sec (stddev: 0.002159318346976914 ) |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, nice add here.
Thoughts on direct_input_field
as the name for an EDTF string passed directly? Feels a bit clunky to me when coming back to this. Maybe edtf_string_field
?
Did the benchmark Github Pages site break? https://ixc.github.io/python-edtf/ |
The page is here: https://ixc.github.io/python-edtf/dev/bench/ . I'll add a link to the readme. |
Add Django checks for the EDTFField's attributes.