forked from liferay/liferay-portal
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LRCI-4167 CX & OSGi module list rename in playwright #174
Open
kenjiheigel
wants to merge
220
commits into
izaera:master
Choose a base branch
from
kenjiheigel:LRCI-4167-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to random string to prevent duplicate or null data
# breaking ## What modules/apps/client-extension/client-extension-type-api/src/main/java/com/liferay/client/extension/type/CommerceCheckoutStepCET.java New method for PaymentMethodKey ## Why We need the new method + property to check whether checkoutStep is a payment checkout step ----
…veloper, prepare for removing "modification check interval" support
…al", set a negative value to disable the manual invalidation of template cache, we do not need this any more as we can depend on ehcache's invalidation. Will send another pull to clean up related API as it is going to have major version bump and hard to backport.
This reverts commit 99c1f0d.
…rint warning message if duplicate directories are found, but use the first one
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LRCI-4167
Hi Ivan, sorry it took us a while to get back to this one. We had a few other priorities come up last quarter, but were finally able to get back to reworking this. Just wanted to send this to you first if you need to rework the local scripts for the cx/module deployment.
The new output will look like this in the rare possibility that there's a duplicate (there are none currently), but we won't make it fail out: