Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRCI-4167 CX & OSGi module list rename in playwright #174

Open
wants to merge 220 commits into
base: master
Choose a base branch
from

Conversation

kenjiheigel
Copy link

@kenjiheigel kenjiheigel commented Aug 16, 2024

https://liferay.atlassian.net/browse/LRCI-4167

Hi Ivan, sorry it took us a while to get back to this one. We had a few other priorities come up last quarter, but were finally able to get back to reworking this. Just wanted to send this to you first if you need to rework the local scripts for the cx/module deployment.

The new output will look like this in the rare possibility that there's a duplicate (there are none currently), but we won't make it fail out:

Deploying Client Extensions in /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/client-extension-web/env/client-extensions.list
Duplicate Client Extensions found for liferay-sample-custom-element-1:
/opt/dev/projects/github/liferay-portal/workspaces/liferay-jethr0-workspace/client-extensions/liferay-sample-custom-element-1
/opt/dev/projects/github/liferay-portal/workspaces/liferay-sample-workspace/client-extensions/liferay-sample-custom-element-1
Please replace "liferay-sample-custom-element-1" in /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/client-extension-web/env/client-extensions.list with one of the following:
liferay-jethr0-workspace/client-extensions/liferay-sample-custom-element-1
liferay-sample-workspace/client-extensions/liferay-sample-custom-element-1
Deploying /opt/dev/projects/github/liferay-portal/workspaces/liferay-jethr0-workspace/client-extensions/liferay-sample-custom-element-1

liferay-translation and others added 30 commits August 14, 2024 10:09
…t to random string to prevent duplicate or null data
# breaking

## What modules/apps/client-extension/client-extension-type-api/src/main/java/com/liferay/client/extension/type/CommerceCheckoutStepCET.java

New method for PaymentMethodKey

## Why

We need the new method + property to check whether checkoutStep is a payment checkout step

----
…veloper, prepare for removing "modification check interval" support
…al", set a negative value to disable the manual invalidation of template cache, we do not need this any more as we can depend on ehcache's invalidation. Will send another pull to clean up related API as it is going to have major version bump and hard to backport.
rafaelfs98 and others added 29 commits August 15, 2024 11:12
…rint warning message if duplicate directories are found, but use the first one
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.