Add start and end times to room class #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take a look over the weekend. Feel free to PM me on discord if you'd like to discuss this further. |
|
This indeed is not tested right now. |
cgtobi
approved these changes
Nov 20, 2023
cgtobi
added a commit
that referenced
this pull request
Dec 15, 2023
* cd: Run publish-to-test-pypi only on development branch * fix devcontainer (#468) * Add start and end times to room class (#469) * Remove deprecated code (#461) * Remove deprecated code * Remove old codeql config * Remove unused fixture * Minor clean up * Refactor async_post_request Signed-off-by: Tobias Sauerwein <[email protected]> --------- Signed-off-by: Tobias Sauerwein <[email protected]> * Split tests and clean up (#471) * split tests * clean up cruft * Fix NLPD to provide energy readings * Add BNLD - Bticino dimmable light * Update readme (#472) * Clean up somfy shutter * Add new bticino scope * update readme * chore(deps): Bump actions/setup-python from 4.7.1 to 5.0.0 (#474) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.1 to 5.0.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.7.1...v5.0.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add missing device type mapping for NIS (#476) * Add power data to NLPD entities (#477) * Clean up (#479) --------- Signed-off-by: Tobias Sauerwein <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Hugo Dupras <[email protected]> Co-authored-by: deosrc <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
cgtobi
added a commit
that referenced
this pull request
Dec 20, 2023
* cd: Run publish-to-test-pypi only on development branch * fix devcontainer (#468) * Add start and end times to room class (#469) * Remove deprecated code (#461) * Remove deprecated code * Remove old codeql config * Remove unused fixture * Minor clean up * Refactor async_post_request Signed-off-by: Tobias Sauerwein <[email protected]> --------- Signed-off-by: Tobias Sauerwein <[email protected]> * Split tests and clean up (#471) * split tests * clean up cruft * Fix NLPD to provide energy readings * Add BNLD - Bticino dimmable light * Update readme (#472) * Clean up somfy shutter * Add new bticino scope * update readme * chore(deps): Bump actions/setup-python from 4.7.1 to 5.0.0 (#474) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.1 to 5.0.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.7.1...v5.0.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add missing device type mapping for NIS (#476) * Add power data to NLPD entities (#477) * Clean up (#479) * Update CHANGELOG.md * Fix nlfe (#480) * Add missing NLFE Legrand dimmer switch * clean up * Update changelog --------- Signed-off-by: Tobias Sauerwein <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Hugo Dupras <[email protected]> Co-authored-by: deosrc <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how best to test this. Maybe I'm missing something but there doesn't seem to be any existing tests for the room class.
Resolves #467