Reordered device type evaluation to prioritize BNS over NRV

[fabianocattaneo]

A room may have both a BNS and one or more NRVs. This situation must be handled as a BNS, not as an NRV.

Summary by Sourcery

Bug Fixes:

• Fix the logic to correctly identify a room as BNS when it contains both BNS and NRV devices.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the evaluate_device_type method in the room.py file to prioritize BNS (Boiler and Netatmo Smart) devices over NRV (Netatmo Radiator Valve) devices when a room contains both types. This change ensures that rooms with both BNS and NRV devices are handled as BNS, which is the desired behavior.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Reordered device type evaluation to prioritize BNS over NRV	Moved the NRV device type check after the BNS device type check Kept the existing logic for other device types (OTM, NATherm1, BNTH) unchanged	src/pyatmo/room.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @fabianocattaneo - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}