Add generic implementation of xorBlock #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.16 makes go.mod mandatory: https://blog.golang.org/go116-module-changes This caused two errors: (1) go build failed: go: cannot find main module, but found .git/config in /home/jakob/go/src/github.com/jacobsa/crypto to create a module there, run: go mod init Fixed by adding go.mod & go.sum. (2) tests failed: subkey.go:47: panic: Finding package: no required module provides package github.com/jacobsa/crypto/testing/cases; to add it: go get github.com/jacobsa/crypto/testing/cases Fixed by adding testing/cases/cases.go.
|
@jacobsa This fixes a build for us against riscv64 on Buildroot, could you have a look at merging? Thanks 👍🏽 |
|
Hi @paralin,
Sure! Do you prefer maintain the fork at aperturerobotics/jacobsa-crypto or piggynl/jacobsa-crypto? I have some ideas on using QEMU on GitHub Action to test packages for different architectures. |
|
@piggynl Since that org already has a number of forked repos under maintenance, I'm happy to put it there. Do we keep the name jacobsa-crypto? I can change the go.mod there to match. OK, changed the go.mod & invited you as a maintainer. |
paralin
added a commit
to paralin/gocryptfs
that referenced
this pull request
Jul 14, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64. Issue: rfjakob#666 Upstream PR: jacobsa/crypto#13 Unaddressed on jacobsa/crypto: jacobsa/crypto#14 (comment) Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to paralin/gocryptfs
that referenced
this pull request
Dec 8, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64. Issue: rfjakob#666 Upstream PR: jacobsa/crypto#13 Unaddressed on jacobsa/crypto: jacobsa/crypto#14 (comment) Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to paralin/gocryptfs
that referenced
this pull request
Dec 8, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64. Issue: rfjakob#666 Upstream PR: jacobsa/crypto#13 Unaddressed on jacobsa/crypto: jacobsa/crypto#14 (comment) Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to paralin/gocryptfs
that referenced
this pull request
Dec 8, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64. Issue: rfjakob#666 Upstream PR: jacobsa/crypto#13 Unaddressed on jacobsa/crypto: jacobsa/crypto#14 (comment) Signed-off-by: Christian Stewart <[email protected]>
rfjakob
pushed a commit
to rfjakob/gocryptfs
that referenced
this pull request
Dec 21, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64. Issue: #666 Upstream PR: jacobsa/crypto#13 Unaddressed on jacobsa/crypto: jacobsa/crypto#14 (comment) Signed-off-by: Christian Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #12 and will fix #13.
The generic implementation doesn't require that it's safe to perform unaligned word-sized loads, but has a poor performance.
Also, I wonder whether the related code can be rewritten to not use unaligned memory accesses?