Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qu 4501 #1556

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Qu 4501 #1556

merged 7 commits into from
Sep 12, 2024

Conversation

Sectimus
Copy link

@Sectimus Sectimus commented Sep 5, 2024

The file input does not retain it's files prior to submit, every time you attach a file, it was overwritten; Which isn't a problem if you are serializing the data yourself, but is a problem if you need to trust that your file input contains your file data.

Before

image

Generic binary data (or binary data whose true type is unknown) is application/octet-stream.

After

image

@Stanton
Copy link
Member

Stanton commented Sep 6, 2024

Dropzone test suite failing so can't be merged, the Node14 environment falls over on github but returns the same failing tests when run locally.

@Sectimus
Copy link
Author

We can't include the --no-sandbox changes by default due to this failing test: (I have highlighted the probable cause)
image

@Stanton Stanton merged commit 81292e4 into develop Sep 12, 2024
8 checks passed
@Stanton Stanton deleted the QU-4501 branch September 12, 2024 06:52
@Stanton Stanton restored the QU-4501 branch September 12, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants