Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to Typescript #27

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rubens21
Copy link

Summary

Adds the plugin grpc-web to support Typescript.
...

Changes

  • Adds a new layer in the protoc_builder intermediate image with the grpc-web gRPC plugin
  • Updates the read me file

Release Notes

  • Added support to Typescript

@@ -49,6 +50,10 @@ RUN mkdir -p /grpc-java && \
rm -Rf /grpc-java && \
rm -Rf /grpc

ARG GRPC_WEB_VERSION
RUN curl -sSLO https://github.com/grpc/grpc-web/releases/download/${GRPC_WEB_VERSION}/protoc-gen-grpc-web-${GRPC_WEB_VERSION}-linux-x86_64 && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubens21 we are using a multi-arch build (for amd64 and arm64). I see that at least in v1.5.0 of GPRC_WEB they publish aarch64 build, so if you want to change this to work with both, we could merge.

I would've preferred to have some test. Right now we test the build by running make proto in jaeger-idl, which I think exercises multiple languages. We could include the new TS output there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants