Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from uber to jaegertracing org #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

objectiser
Copy link
Contributor

Which problem is this PR solving?

Although repo is hosted in jaegertracing github org, the jaeger-lib packages are still referenced using the github.com/uber location. This PR updates to use the jaegertracing org.

Related to #47

Short description of the changes

Replace github.com/uber with github.com/jaegertracing when referencing the jaeger-lib packages.

Signed-off-by: Gary Brown [email protected]

@codecov
Copy link

codecov bot commented Nov 2, 2018

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #59   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          25     25           
  Lines         694    694           
=====================================
  Hits          694    694
Impacted Files Coverage Δ
metrics/adapters/cache.go 100% <ø> (ø) ⬆️
metrics/go-kit/expvar/factory.go 100% <ø> (ø) ⬆️
metrics/adapters/tagless.go 100% <ø> (ø) ⬆️
metrics/expvar/factory.go 100% <ø> (ø) ⬆️
metrics/go-kit/factory.go 100% <ø> (ø) ⬆️
client/log/go-kit/logger.go 100% <ø> (ø) ⬆️
metrics/go-kit/influx/factory.go 100% <ø> (ø) ⬆️
metrics/metricstest/metricstest.go 100% <ø> (ø) ⬆️
metrics/adapters/factory.go 100% <ø> (ø) ⬆️
metrics/prometheus/factory.go 100% <ø> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc5c31...ec43e70. Read the comment docs.

@yurishkuro
Copy link
Member

We had a discussion internally, and propose to de-scope this. The API change to the factory is not as damaging as the package name change. With the release of jaeger-lib 2.0 we can still do a minor release of jaeger client without breaking most users, but if we change the package name then all users who configure metrics with jaeger client will be broken. It will require a major release of the client. The aesthetic benefits of the package name change do not justify this disruption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants