Fixed PR review comments

jagan-parthiban · Aug 23, 2023 · 47497e1 · 47497e1
1 parent 5035ce4
commit 47497e1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/lib/go-tc/profile_parameters.go b/lib/go-tc/profile_parameters.go
@@ -95,16 +95,3 @@ type ProfileParameterV50 struct {
 	Parameter   string    `json:"parameter"`
 	ParameterID int       `json:"parameterId"`
 }
-
-// ProfileParameterNullableV5 is the latest minor version of the major version 5
-type ProfileParameterNullableV5 ProfileParameterNullableV50
-
-// ProfileParameterNullableV50 is identical to ProfileParameter, except that its
-// fields are reference values, which allows them to be nil.
-type ProfileParameterNullableV50 struct {
-	LastUpdated *time.Time `json:"lastUpdated" db:"last_updated"`
-	Profile     *string    `json:"profile" db:"profile"`
-	ProfileID   *int       `json:"profileId" db:"profile_id"`
-	Parameter   *string    `json:"parameter" db:"parameter"`
-	ParameterID *int       `json:"parameterId" db:"parameter_id"`
-}
diff --git a/traffic_ops/traffic_ops_golang/profileparameter/profile_parameters.go b/traffic_ops/traffic_ops_golang/profileparameter/profile_parameters.go
@@ -243,6 +243,7 @@ func GetProfileParameter(w http.ResponseWriter, r *http.Request) {
 	where, orderBy, pagination, queryValues, errs := dbhelpers.BuildWhereAndOrderByAndPagination(inf.Params, queryParamsToQueryCols)
 	if len(errs) > 0 {
 		api.HandleErr(w, r, tx.Tx, http.StatusBadRequest, util.JoinErrs(errs), nil)
+		return
 	}
 
 	if inf.Config.UseIMS {