Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCK tests for find queries using parameter names #277

Conversation

njr-11
Copy link
Contributor

@njr-11 njr-11 commented Sep 28, 2023

This area of the specification should be consistent in how is currently written and Gavin's pull to make changes, so we should be able to add TCK tests. The following scenarios are included in this pull:

  • Find a single entity, querying by entity attributes with names that match the method parameter names.
  • Find a single entity that might or might not exist (return type of Optional), querying by entity attributes with names that match the method parameter names.
  • Find a list of entities, querying by entity attributes with names that match the method parameter names, with results capped by a Limit parameter and sorted according to a variable arguments Sort parameter.
  • Find a page of entities, with entity attributes identified by the parameter names and matching the parameter values.

@njr-11 njr-11 added the test Something test-related label Sep 28, 2023
@njr-11 njr-11 added this to the Jakarta Data 1.0 milestone Sep 28, 2023
@njr-11 njr-11 mentioned this pull request Sep 28, 2023
79 tasks
@njr-11 njr-11 merged commit 5d2d365 into jakartaee:main Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Something test-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants