Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the Update annotation #291

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Enhance the Update annotation #291

merged 6 commits into from
Oct 12, 2023

Conversation

otaviojava
Copy link
Contributor

Changes

  • Include more documentation to Update annotation.

It is a start to discuss.

njr-11
njr-11 requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work. I added some suggestions to describe what happens with the return value when entities to update are not found in the database or have a version that doesn't match.

api/src/main/java/jakarta/data/repository/Update.java Outdated Show resolved Hide resolved
api/src/main/java/jakarta/data/repository/Update.java Outdated Show resolved Hide resolved
api/src/main/java/jakarta/data/repository/Update.java Outdated Show resolved Hide resolved
njr-11
njr-11 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. Approving.

@otaviojava otaviojava merged commit b7bcb54 into main Oct 12, 2023
2 checks passed
@otaviojava otaviojava deleted the update-annotation branch October 12, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njr-11 njr-11 njr-11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otaviojava @njr-11