Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposed revisions to entity programming model #389

Merged
merged 4 commits into from
Dec 6, 2023
Merged

proposed revisions to entity programming model #389

merged 4 commits into from
Dec 6, 2023

Conversation

gavinking
Copy link
Contributor

Thoughts?

@gavinking gavinking marked this pull request as draft December 5, 2023 17:10
njr-11
njr-11 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Nice improvements! I spotted one minor grammar correction to make removing an extra comma.

spec/src/main/asciidoc/repository.asciidoc Outdated Show resolved Hide resolved
@njr-11 njr-11 marked this pull request as ready for review December 6, 2023 14:34
njr-11
njr-11 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional commit looks good as well.

@gavinking
Copy link
Contributor Author

The additional commit looks good as well.

Shall I squash it and merge it?

@njr-11
Copy link
Contributor

njr-11 commented Dec 6, 2023

The additional commit looks good as well.

Shall I squash it and merge it?

Yes

@gavinking gavinking merged commit dd65449 into jakartaee:main Dec 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njr-11 njr-11 njr-11 approved these changes

@otaviojava otaviojava otaviojava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavinking @njr-11 @otaviojava