Race Condition Fix #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h to install helm on a server Signed-off-by: Jesse Millar <[email protected]>
jessemillar
commented
Jan 29, 2020
| @@ -48,11 +48,11 @@ elif [ ! -f "$LOCAL_HELM" ]; then | |||
| GET_HELM_VERSION $KNOWN_VERSION | |||
| fi | |||
|
|
|||
| TARGET_VERSION=$($LOCAL_HELM version --template '{{ .Server.SemVer }}') | |||
| TARGET_VERSION=$($LOCAL_HELM version --template '{{ .Server.SemVer }}' || echo $KNOWN_VERSION) | |||
There was a problem hiding this comment.
This is the only non-whitespace change.
vitalilaviy
reviewed
Feb 2, 2022
| @@ -1,6 +1,8 @@ | |||
| # Automatically run the correct version of helm every time | |||
|
|
|||
| This script will read the version of the Helm server you are running. It will then download a new version of `helm` if needed and run your command with new `helm`. I named it `h` since most everyone appears to alias `helm` to `h` anyway. | |||
| This script will read the version of the Helm server you are running, download a new version of the `helm` CLI to your machine if needed, and run your command with a version of `helm` that matches your server. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition where I was unable to use a clean install of
hto install Helm on a server.