Ble enhancements#124 #129
Merged
Ble enhancements#124 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add "Subject" field to notification object - Remove length check for notification fields, because empty fields have a length of 0 which causes issues with the string termination main: - Rename log level for main in Kconfig - Add log level for main application - Use short payload of a notification instead of the long version Signed-off-by: Daniel Kampert <[email protected]>
- Add log level for Bluetooth code - Replace include guards with "pragma once" Template app: - Add log level for template app Settings app: - Add log level for settings app Signed-off-by: Daniel Kampert <[email protected]>
Closed
24 tasks
Kampi
force-pushed
the
BLE_enhancements#124
branch
from
ac6e4db
to
fb08d5b
Compare
- Fix compile errors because of multible log tags in Bluetooth code - Undo auto insertion in settings file by VS Code - Change log level for notification data to debug
Kampi
force-pushed
the
BLE_enhancements#124
branch
from
fb08d5b
to
80163b1
Compare
jakkra
reviewed
Nov 20, 2023
| @@ -220,6 +231,13 @@ static void on_pairing_enable_changed(lv_setting_value_t value, bool final) | |||
| { | |||
| if (final) { | |||
| ble_comm_set_pairable(true); | |||
|
|
|||
| if (!k_work_delayable_is_pending(&ble_pairing_dwork)) { | |||
There was a problem hiding this comment.
You can replace all of this with one in the top of file:
K_WORK_DELAYABLE_DEFINE(ble_pairing_dwork, ble_pairing_work_handler)
And then always call k_work_reschedule here, I think it will schedule if not already scheduled, and re-schedule i.e. prolong to 60s if timer already running.
jakkra
reviewed
Nov 20, 2023
| @@ -353,7 +353,7 @@ static void open_notification_popup(void *data) | |||
| lv_group_set_default(temp_group); | |||
| lv_indev_set_group(enc_indev, temp_group); | |||
| zsw_vibration_run_pattern(ZSW_VIBRATION_PATTERN_NOTIFICATION); | |||
| zsw_notification_popup_show(not->title, not->body, not->src, not->id, on_popup_notifcation_closed, 10); | |||
| zsw_notification_popup_show(not->title, not->sender, not->src, not->id, on_popup_notifcation_closed, 10); | |||
There was a problem hiding this comment.
Sender is body? What changes here?
There was a problem hiding this comment.
It shortens the message that is shown in the notification preview. So you don´t have the full text here. Instead, there is shown something like "ABCDE12345678..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLE:
main:
Template app:
Settings app: