Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flick In event don´t put the device into inactive mode when the display always on is enabled #163

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Kampi
Copy link
Collaborator

@Kampi Kampi commented Nov 28, 2023

No description provided.

- Flick In event don´t put the device into inactive mode when display always on is enabled
@ldab
Copy link
Collaborator

ldab commented Nov 28, 2023

It works for me, when looking at you did, I was expecting to get the settings by example settings_storage_get() but whatever you did, works haha.

Hold on... doesn't work here, I think the debugger was keeping the screen on

@jakkra
Copy link
Owner

jakkra commented Nov 28, 2023

@ldab this PR should be OK, at least from looking at it. It's a different feature if apps want to keep the screen from going to sleep. That would be implemented some other way. It should not control it though settings, this should be done in another way

@jakkra jakkra merged commit 5c1f8f0 into main Nov 28, 2023
16 checks passed
@Kampi
Copy link
Collaborator Author

Kampi commented Nov 28, 2023

It works for me, when looking at you did, I was expecting to get the settings by example settings_storage_get() but whatever you did, works haha.

Hold on... doesn't work here, I think the debugger was keeping the screen on

Are you sure? I tested it again and the screen on my watch has been active for ~2h now, even with flick events. Also, it's more of a "dirty" fix, because (as @jakkra mentioned it) there is only a global option to disable screen off in the settings and I have added a check for it. The better solution is to add some sort of API for apps to prevent it. I added it as Issue (#164 ).

@Kampi Kampi deleted the Fix#162 branch November 30, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flick out need to check display always on settings before turning screen off
3 participants