-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix drop connection by RabbitMQ #120
Conversation
If RabbitMQ closed the connection due to incorrect login/password
If RabbitMQ closed the connection due to incorrect login/password
Thank you for filing this PR, could you rebase on the latest changes in master now that #106, and do you think it is possible to test this? |
I tested on my test server and now works on the production server |
@viras777 Thanks for the update. Any clue what it fails for certain jobs? |
In the function awaitConnectionTune I added interception of all exceptions to be able to process in reject. Because of this, the tests do not pass, they expect another type of exception |
separate into two different patches
Fix bug with missing heartbeat
Sometimes there are missed hearbeats with an error on the rabbitmq server: "missing heartbeats from client, timeout: 60s" and bunny take 100 CPU for a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, sorry for the late merge. Planning to release this in a few days
Odd, CI blow up, but not on lowest possible dependencies. Will fix before releasing |
Fix if RabbitMQ closed the connection due to incorrect login/password.
Similar problems in here issues:
Change state to error when ClientException is throw #115
or
Failing connections cause exceptions thrown outside of Promise #74
or
ClientException #59