Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on nth and only-tags PEG specials #233

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Add documentation on nth and only-tags PEG specials #233

merged 1 commit into from
Sep 14, 2024

Conversation

katomuso
Copy link
Contributor

No description provided.

@sogaiu
Copy link
Contributor

sogaiu commented Sep 13, 2024

I think nth has an optional tag argument...at least that's what it looks like to me here.

If that's the case, may be it's good to have that in the signature using ?tag or some such? FWIW, right below the proposed last change is uint which has ?tag at the end of its signature.

@katomuso
Copy link
Contributor Author

I think nth has an optional tag argument...at least that's what it looks like to me here.

If that's the case, may be it's good to have that in the signature using ?tag or some such? FWIW, right below the proposed last change is uint which has ?tag at the end of its signature.

You are right, I've made the change.

@sogaiu
Copy link
Contributor

sogaiu commented Sep 13, 2024

Thanks for the update!

@bakpakin bakpakin merged commit 8f4ee5c into janet-lang:master Sep 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants