Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global.Mustache triggers JScript runtime error #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nagaozen
Copy link
Contributor

Because ASP/WSH script environments are language agnostic, one cannot assume it can be managed like a first-class javascript object. By changing the javascript global explicit assignment pattern to implicit assignment pattern (less is more) it works as expected.

Error before the change:
Microsoft JScript runtime error '800a01b6'
Object doesn't support this property or method
/lib/axe/classes/Parsers/mustache.asp, line 163

Because ASP/WSH script environments are language agnostic, one cannot assume it can be managed like a first-class javascript object. By changing the javascript global explicit assignment pattern to implicit assignment pattern (less is more) it works as expected.
@phillipj
Copy link
Collaborator

Thanks for looking after us @nagaozen. I thought I remembered you got something similar merged last year -> 60c2da8.

Too ensure this regression doesn't sneek its way back in again, any thoughts about writing a unit tests for this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants