Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GPT Homepage and Details Page #157

Merged
merged 14 commits into from
Jul 11, 2023

Conversation

Zaperex
Copy link
Member

@Zaperex Zaperex commented Jun 30, 2023

What does this PR do / why we need it

Adds the GPT Homepage and Details Page to provide discovery for the sample GPTs we have available.

Which issue(s) does this PR fix

Fixes #153
Fixes #154

PR acceptance criteria

  • Unit Tests
  • E2E Tests
  • Documentation

How to test changes / Special notes to the reviewer

@Zaperex Zaperex self-assigned this Jun 30, 2023
@Zaperex
Copy link
Member Author

Zaperex commented Jun 30, 2023

Currently the rawGithubUrl links that we pull the README.md files from currently point to a temporary repository since the relevant files are not present in the software-templates repo.
This PR would need janus-idp/software-templates#139 to be merged before we can update to the correct links.

Additionally the new GPT proposal link also links to a temporary repository since the relevant issue template is not present in the software-templates repo.
Similarily janus-idp/software-templates#138 needs to be merged to update the proposal link to the correct link.

@Zaperex Zaperex requested a review from schultzp2020 July 5, 2023 18:50
@Zaperex Zaperex marked this pull request as ready for review July 5, 2023 18:50
@Zaperex Zaperex requested a review from a team as a code owner July 5, 2023 18:50
Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schultzp2020 schultzp2020 merged commit adeee6e into janus-idp:main Jul 11, 2023
1 check passed
@Zaperex Zaperex deleted the add-gpt-pages branch July 12, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GPT Details Page to janus-idp.github.io Add GPT Home Page to janus-idp.github.io
2 participants