Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for filtering out satisfied requirements. #110

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

jaraco
Copy link
Owner

@jaraco jaraco commented Jul 16, 2024

This approach was a performance optimization and intended as a means to augment an existing environment and avoid re-installing packages that were already satisfied. This behavior contradicts the efforts in #104 to run independent of the environment in which pip-run is installed.

Closes #51.

This approach was a performance optimization and intended as a means to augment an existing environment and avoid re-installing packages that were already satisfied. This behavior contradicts the efforts in #104 to run independent of the environment in which pip-run is installed.

Closes #51.
@jaraco jaraco merged commit 651b512 into main Jul 16, 2024
24 checks passed
@jaraco jaraco deleted the debt/51-ignore-existing branch July 16, 2024 20:23
Comment on lines -414 to -416
* - re-use existing environment
- ✓
-
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On further consideration, this feature still exists and still distinguishes pip-run from pipx. Even though existing satisfied dependencies will be overlayed, the existing target environment will still be present, and unspecified dependencies will be available from that environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for already-installed requirements
1 participant