Skip to content

Commit

Permalink
pkp/pkp-lib#9992 Address code review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jardakotesovec committed Jul 2, 2024
1 parent 5a77c55 commit ca0ac83
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/components/ListPanel/doi/DoiFailedActionDialogBody.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<p>{{ t('manager.dois.update.partialFailure') }}</p>
<ul>
<li v-for="errorMessage in failedDoiActions" :key="errorMessage.index">
<ul class="list-inside list-disc">
<li v-for="(errorMessage, index) in failedDoiActions" :key="index">
{{ errorMessage }}
</li>
</ul>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -423,4 +423,3 @@ export default {
}
}
</style>
./HighlightsEditModal.vue
2 changes: 1 addition & 1 deletion src/components/Modal/SideModal.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Side modal has been introduced in 3.5 all existing modals, including jquery lega

## Usage

Its important to create modals as separate files, which works best with our [useModal](../?path=/docs/composables-usemodal--docs#opensidemodal) composable. Also having them defined as individual components ensures that the `setup` function and any other component life cycle event are triggered as modal is opened/closed. Therefore its easier to control when for example to fetch data from API.
It's important to create modals as separate files, which works best with our [useModal](../?path=/docs/composables-usemodal--docs#opensidemodal) composable. Also having them defined as individual components ensures that the `setup` function and any other component life cycle event are triggered as modal is opened/closed. Therefore, it's easier to control when for example to fetch data from API.

## Accessibility

Expand Down
2 changes: 1 addition & 1 deletion src/composables/useModal.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {Primary, Controls, Stories, Meta, ArgTypes} from '@storybook/blocks';

## openDialog

Dialog purpose is to display simple feedback like success and error messages. Or request confirmation for example before deleting some content. Import `useModal` composable and use the openDialog() method to create a dialog. Check [Dialog](../?path=/docs/components-dialog--docs) component for more details on available props.
Dialog component's purpose is to display simple feedback like success and error messages. Or request confirmation for example before deleting some content. Import `useModal` composable and use the openDialog() method to create a dialog. Check [Dialog](../?path=/docs/components-dialog--docs) component for more details on available props.

```html
<template>
Expand Down
3 changes: 3 additions & 0 deletions src/pages/submissionWizard/ReconfigureSubmissionModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
import SideModalBody from '@/components/Modal/SideModalBody.vue';
import SideModalLayoutBasic from '@/components/Modal/SideModalLayoutBasic.vue';
import PkpForm from '@/components/Form/Form.vue';
import {useLocalize} from '@/composables/useLocalize';
const {t} = useLocalize();
defineProps({
reconfigureSubmissionForm: {type: Object, required: true},
Expand Down

0 comments on commit ca0ac83

Please sign in to comment.